1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474
//! Sharp display driver
//!
//! This is an early attempt at a "frame buffer" style display driver. It provides a
//! [emb_display service][kernel::services::emb_display] server, and uses the
//! d1-core specific [SpiSender][crate::drivers::spim::SpiSender] service as an SPI
//! "backend" for rendering.
//!
//! This implementation is sort of a work in progress, it isn't really a *great*
//! long-term solution, but rather "okay for now".
//!
//! A framebuffer of pixels is allocated for the entire display on registration.
//! This could be, for example, 400x240 pixels.
//!
//! The driver will then allow for a certain number of "sub frames" to be requested.
//!
//! These sub frames could be for the entire display (400x240), or a portion of it,
//! for example 200x120 pixels.
//!
//! Clients of the driver can draw into the sub-frames that they receive, then send
//! them back to be rendered into the total frame. Any data in the client's sub-frame
//! will replace the current contents of the whole frame buffer.
//!
//! ## Wire format
//!
//! Reference: <https://www.sharpsde.com/fileadmin/products/Displays/2016_SDE_App_Note_for_Memory_LCD_programming_V1.3.pdf>
use core::time::Duration;
use embedded_graphics::{
image::{Image, ImageRaw},
pixelcolor::Gray8,
prelude::*,
primitives::Rectangle,
};
use kernel::{
comms::kchannel::{KChannel, KConsumer},
maitake::sync::{Mutex, WaitCell},
mnemos_alloc::containers::{Arc, FixedVec},
registry::Message,
services::emb_display::{EmbDisplayService, FrameChunk, FrameError, Request, Response},
Kernel,
};
use crate::spim::SpiSenderClient;
const WIDTH: usize = 400;
const HEIGHT: usize = 240;
// Every pixel is one bit
const WIDTH_BYTES: usize = WIDTH / 8;
// Foreach LINE (240x) - 52 bytes total:
// * 1 byte for line number
// * (400bits / 8 = 50bytes) of data (one bit per pixel)
// * 1 "dummy" byte
const LINE_COMMAND_IDX: usize = 0;
const LINE_COMMAND_BYTES: usize = 1;
const LINE_DUMMY_BYTES: usize = 1;
const LINE_DATA_BYTES: usize = WIDTH_BYTES;
const LINE_BYTES: usize = LINE_COMMAND_BYTES + LINE_DATA_BYTES + LINE_DUMMY_BYTES;
// Every FRAME gets a 1 byte command, all of the lines, and one extra dummy byte
const FRAME_COMMAND_IDX: usize = 0;
const FRAME_COMMAND_BYTES: usize = 1;
const FRAME_DUMMY_BYTES: usize = 1;
const FRAME_DATA_BYTES: usize = HEIGHT * LINE_BYTES;
const FRAME_BYTES: usize = FRAME_COMMAND_BYTES + FRAME_DATA_BYTES + FRAME_DUMMY_BYTES;
mod commands {
pub const WRITE_LINE: u8 = 0b0000_0001;
pub const VCOM_MASK: u8 = 0b0000_0010;
}
/// Implements the [`EmbDisplayService`] service interface
pub struct SharpDisplay;
impl SharpDisplay {
pub const WIDTH: usize = WIDTH;
pub const HEIGHT: usize = HEIGHT;
/// Register the driver instance
///
/// Registration will also start the simulated display, meaning that the display
/// window will appear.
pub async fn register(kernel: &'static Kernel, max_frames: usize) -> Result<(), FrameError> {
let frames = FixedVec::new(max_frames).await;
let mut linebuf = FixedVec::new(FRAME_BYTES).await;
for _ in 0..FRAME_BYTES {
let _ = linebuf.try_push(0);
}
let ctxt = Arc::new(Mutex::new(Context {
sdisp: FullFrame::new(),
vcom: false,
}))
.await;
let (cmd_prod, cmd_cons) = KChannel::new_async(1).await.split();
let commander = CommanderTask {
cmd: cmd_cons,
display_info: DisplayInfo {
frames,
frame_idx: 0,
},
ctxt: ctxt.clone(),
};
let vcom = VCom {
kernel,
ctxt: ctxt.clone(),
};
let draw = Draw {
kernel,
buf: linebuf,
spim: SpiSenderClient::from_registry(kernel).await.unwrap(),
ctxt,
};
kernel.spawn(commander.cmd_run()).await;
kernel.spawn(vcom.vcom_run()).await;
kernel.spawn(draw.draw_run()).await;
kernel
.with_registry(|reg| reg.register_konly::<EmbDisplayService>(&cmd_prod))
.await
.map_err(|_| FrameError::DisplayAlreadyExists)?;
Ok(())
}
}
/// One entire frame, stored one bit per pixel
struct FullFrame {
frame: [[u8; WIDTH_BYTES]; HEIGHT],
}
impl FullFrame {
pub fn new() -> Self {
Self {
frame: [[0u8; WIDTH_BYTES]; HEIGHT],
}
}
}
impl FullFrame {
#[inline]
fn set_px(&mut self, x: usize, y: usize, color: Gray8) {
if x >= WIDTH || y > HEIGHT {
return;
}
let byte_x = x / 8;
let bit_x = x % 8;
if color.luma() > 128 {
self.frame[y][byte_x] |= 1 << (bit_x as u8);
} else {
self.frame[y][byte_x] &= !(1 << (bit_x as u8))
}
}
}
impl Dimensions for FullFrame {
fn bounding_box(&self) -> embedded_graphics::primitives::Rectangle {
Rectangle::new(
Point { x: 0, y: 0 },
Size {
width: WIDTH as u32,
height: HEIGHT as u32,
},
)
}
}
impl DrawTarget for FullFrame {
type Color = Gray8;
type Error = ();
fn draw_iter<I>(&mut self, pixels: I) -> Result<(), Self::Error>
where
I: IntoIterator<Item = Pixel<Self::Color>>,
{
for px in pixels {
self.set_px(px.0.x as usize, px.0.y as usize, px.1)
}
Ok(())
}
}
//////////////////////////////////////////////////////////////////////////////
// Helper tasks
//
// Friends to help us make things happen
//////////////////////////////////////////////////////////////////////////////
/// VCom - Once a second, update the vcom flag which is sent in every message.
///
/// TODO(AJM): The Beepberry uses a GPIO to toggle this rather than a bit in the
/// SPI messages. This struct should be expanded to toggle the EXT pin at this
/// rate instead, possibly as an optional field.
struct VCom {
kernel: &'static Kernel,
ctxt: Arc<Mutex<Context>>,
}
impl VCom {
#[tracing::instrument(skip(self))]
pub async fn vcom_run(self) {
loop {
self.kernel.sleep(Duration::from_secs(1)).await;
let mut c = self.ctxt.lock().await;
c.vcom = !c.vcom;
tracing::debug!(vcom = c.vcom, "Toggling vcom");
}
}
}
/// Drawing task
///
/// This task draws whenever there are pending (or "dirty") changes to the frame
/// buffer, or at a base rate of 2Hz. At the moment, we only do a full redraw to
/// ensure that VCOM is updated periodically.
///
/// ## Room for improvement
///
/// In the future, we can likely send a "no-op" command instead of a full frame
/// redraw if the dirty flag has not been set, as a power optimization or latency
/// improvement. This is not necessary if we are using GPIO VCOM instead of SPI
/// VCOM toggling.
///
/// We could also keep track of "dirty lines" instead of just a whole "dirty frame",
/// and only pull lines that have changed. This would help when typing a on a single
/// line, and only one font-height needs to be redrawn.
///
/// For example: a single line is 52 * 8 bits, or 416 bits, or 208us at 2MHz. For
/// sending an entire 240 line frame, this is 208 * 240us, or 49_920 us. If we can
/// only are updating one 12pt font line, which is 15 pixels tall, this would reduce
/// our sending time from 49.9ms to 3.1ms.
struct Draw {
kernel: &'static Kernel,
buf: FixedVec<u8>,
spim: SpiSenderClient,
ctxt: Arc<Mutex<Context>>,
}
impl Draw {
#[tracing::instrument(skip(self))]
async fn draw_run(mut self) {
loop {
let c = self.ctxt.lock().await;
// render into the buffer
let mut cmd = commands::WRITE_LINE;
if c.vcom {
cmd |= commands::VCOM_MASK;
}
// Write the command
self.buf.as_slice_mut()[FRAME_COMMAND_IDX] = cmd;
// Now we need to write all the lines, zip together the dest buffer
// with our current frame buffer
let out_lines =
self.buf.as_slice_mut()[FRAME_COMMAND_BYTES..].chunks_exact_mut(LINE_BYTES);
let in_lines = c.sdisp.frame.iter();
let lines = out_lines.zip(in_lines);
for (line, (oline, iline)) in &mut lines.enumerate() {
// Lines are 1-indexed on the wire
oline[LINE_COMMAND_IDX] = (line as u8) + 1;
// We keep our internal frame buffer in the same format as the wire
oline[LINE_COMMAND_BYTES..][..LINE_DATA_BYTES].copy_from_slice(iline);
// We don't need to write the dummy byte for the line
}
// Drop the mutex once we're done using the framebuffer data
drop(c);
// We don't need to write the (extra) dummy byte for the frame
self.buf = self.spim.send_wait(self.buf).await.map_err(drop).unwrap();
// Wait a reasonable amount of time to redraw
let _ = self
.kernel
.timeout(Duration::from_millis(500), DIRTY.wait())
.await;
}
}
}
/// This task is spawned by the call to [`SharpDisplay::register`]. It is a single
/// async function that will process requests, and periodically redraw the
/// framebuffer.
struct CommanderTask {
cmd: KConsumer<Message<EmbDisplayService>>,
display_info: DisplayInfo,
ctxt: Arc<Mutex<Context>>,
}
impl CommanderTask {
/// The entrypoint for the driver execution
#[tracing::instrument(skip(self))]
async fn cmd_run(mut self) {
// This loop services incoming client requests.
//
// Generally, don't handle errors when replying to clients, this indicates that they
// sent us a message and "hung up" without waiting for a response.
loop {
let msg = self.cmd.dequeue_async().await.map_err(drop).unwrap();
let Message {
msg: mut req,
reply,
} = msg;
match &mut req.body {
Request::NewFrameChunk {
start_x,
start_y,
width,
height,
} => {
let res = self
.display_info
.new_frame(*start_x, *start_y, *width, *height)
.await
.map(Response::FrameChunkAllocated);
if res.is_ok() {
tracing::debug!(start_x, start_y, width, height, "allocated frame",);
} else {
tracing::warn!(
start_x,
start_y,
width,
height,
"refused to allocate frame"
);
}
let resp = req.reply_with(res);
let _ = reply.reply_konly(resp).await;
}
Request::Draw(fc) => match self.display_info.remove_frame(fc.frame_id) {
Ok(_) => {
let (x, y) = (fc.start_x, fc.start_y);
let raw_img = frame_display(fc).unwrap();
let image = Image::new(&raw_img, Point::new(x, y));
let mut guard = self.ctxt.lock().await;
tracing::debug!("Drawing frame");
image.draw(&mut guard.sdisp).unwrap();
DIRTY.wake();
// Drop the guard before we reply so we don't hold it too long.
drop(guard);
let _ = reply
.reply_konly(req.reply_with(Ok(Response::FrameDrawn)))
.await;
}
Err(e) => {
tracing::warn!("Refused to draw frame");
let _ = reply.reply_konly(req.reply_with(Err(e))).await;
}
},
Request::Drop(fc) => {
let _ = match self.display_info.remove_frame(fc.frame_id) {
Ok(_) => {
tracing::debug!("Dropped frame");
reply
.reply_konly(req.reply_with(Ok(Response::FrameDropped)))
.await
}
Err(e) => reply.reply_konly(req.reply_with(Err(e))).await,
};
}
}
}
}
}
//////////////////////////////////////////////////////////////////////////////
// Helper types and methods
//////////////////////////////////////////////////////////////////////////////
/// Shared state between tasks
struct Context {
sdisp: FullFrame,
vcom: bool,
}
/// Waiter for "changes have been made to the working frame buffer"
static DIRTY: WaitCell = WaitCell::new();
/// Create and return a Simulator display object from raw pixel data.
///
/// Pixel data is turned into a raw image, and then drawn onto a SimulatorDisplay object
/// This is necessary as a e-g Window only accepts SimulatorDisplay object
/// On a physical display, the raw pixel data can be sent over to the display directly
/// Using the display's device interface
fn frame_display(fc: &mut FrameChunk) -> Result<ImageRaw<Gray8>, ()> {
let raw_image: ImageRaw<Gray8>;
raw_image = ImageRaw::<Gray8>::new(fc.bytes.as_slice(), fc.width);
Ok(raw_image)
}
struct FrameInfo {
frame: u16,
}
struct DisplayInfo {
frame_idx: u16,
frames: FixedVec<FrameInfo>,
}
impl DisplayInfo {
// Returns a new frame chunk
async fn new_frame(
&mut self,
start_x: i32,
start_y: i32,
width: u32,
height: u32,
) -> Result<FrameChunk, FrameError> {
let fidx = self.frame_idx;
self.frame_idx = self.frame_idx.wrapping_add(1);
self.frames
.try_push(FrameInfo { frame: fidx })
.map_err(|_| FrameError::NoFrameAvailable)?;
let size = (width * height) as usize;
// TODO: So, in the future, we might not want to ACTUALLY allocate here. Instead,
// we might want to allocate ALL potential frame chunks at registration time and
// hand those out, rather than requiring an allocation here.
//
// TODO: We might want to do ANY input checking here:
//
// * Making sure the request is smaller than the actual display
// * Making sure the request exists entirely within the actual display
let mut bytes = FixedVec::new(size).await;
for _ in 0..size {
let _ = bytes.try_push(0);
}
let fc = FrameChunk {
frame_id: fidx,
bytes,
start_x,
start_y,
width,
height,
};
Ok(fc)
}
fn remove_frame(&mut self, frame_id: u16) -> Result<(), FrameError> {
let mut found = false;
unsafe {
// safety: This only removes items, and will not cause a realloc
self.frames.as_vec_mut().retain(|fr| {
let matches = fr.frame == frame_id;
found |= matches;
!matches
});
}
if found {
Ok(())
} else {
Err(FrameError::NoSuchFrame)
}
}
}